ConicGradient: add conic sample by Nor-s · Pull Request #66 · thorvg/thorvg.example

Nor-s · 2026-08-24T04:25:49Z

Port the RadialGradient example to demonstrate conic gradients.
Press Space to inspect the seam and verify the rendering quality.

Screenshot

Screen.Recording.2026-08-24.at.13.25.09.mov

Copilot

Pull request overview

Adds a new ThorVG example demonstrating conic gradients (ported from the existing radial gradient sample) with an interactive seam/angle inspection mode to help validate rendering quality.

Changes:

Introduces a new ConicGradient example rendering multiple shapes with conic gradient fills.
Adds Space-key handling to rotate the conic gradient angle for seam inspection.
Registers the new example source in the Meson build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/meson.build	Adds `ConicGradient.cpp` to the example build sources.
src/ConicGradient.cpp	New conic gradient example with interactive angle adjustment via Space key.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

hermet · 2026-09-21T06:31:51Z

@Nor-s could you please update this?

Copilot

Copilot review overview

🟡 Changes recommended

Critical compilation issues remain in the content and keyboard callback APIs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 1

Open (3)

Fix Example::content signature to match the base class · New
Update key handling to the toolkit API and preserve Escape handling · New
Include <cmath> for fmodf declaration · New

Resolved since last review (1)

angle increases without bound on each Space press. Over a long session this can reduce precision…

hermet · 2026-09-21T07:12:41Z

Could you please include a similar number of colors in the example?

see: thorvg/thorvg#1216

Copilot

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (3)

Update key handling to the toolkit API and preserve Escape handling
Fix Example::content signature to match the base class
Include <cmath> for fmodf declaration

Nor-s · 2026-09-21T07:25:04Z

Could you please include a similar number of colors in the example?

see: thorvg/thorvg#1216

@hermet I have updated. Thank you.

Copilot

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: None

hermet · 2026-09-21T07:29:34Z

@Nor-s How about applying it to the center circle?

Nor-s · 2026-09-21T07:50:08Z

@Nor-s How about applying it to the center circle?

Copilot

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

hermet

@Nor-s please add tvgexam::verify() - api test for the conic specific functions.

hermet · 2026-09-21T12:22:13Z

see: #73

- Port the RadialGradient example to demonstrate conic gradients. - Press Space to inspect the seam and verify the rendering quality. Issue: thorvg/thorvg#4347

Copilot

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Copilot AI lite review requested due to automatic review settings August 24, 2026 04:25

Nor-s requested a review from hermet as a code owner August 24, 2026 04:25

Copilot started reviewing on behalf of Nor-s August 24, 2026 04:26 View session

Nor-s mentioned this pull request Aug 24, 2026

Introduce the conic gradient thorvg/thorvg#4699

Merged

Nor-s self-assigned this Aug 24, 2026

Nor-s added the addition Adding a new example label Aug 24, 2026

Nor-s marked this pull request as draft August 24, 2026 04:27

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread src/ConicGradient.cpp Outdated

Nor-s force-pushed the nor-s/conic branch from 3fdf405 to 8df10a0 Compare August 24, 2026 04:30

hermet force-pushed the main branch from c09fa74 to c66173b Compare August 27, 2026 15:53

Nor-s force-pushed the nor-s/conic branch from 8df10a0 to 41a7654 Compare September 21, 2026 06:38

Nor-s marked this pull request as ready for review September 21, 2026 06:38

Nor-s requested a review from tinyjin as a code owner September 21, 2026 06:38

Copilot AI review requested due to automatic review settings September 21, 2026 06:38

Copilot started reviewing on behalf of Nor-s September 21, 2026 06:38 View session

Nor-s marked this pull request as draft September 21, 2026 06:40

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread src/ConicGradient.cpp Outdated

Comment thread src/ConicGradient.cpp Outdated

Comment thread src/ConicGradient.cpp Outdated

Nor-s force-pushed the nor-s/conic branch from 41a7654 to 55d113b Compare September 21, 2026 06:42

hermet marked this pull request as ready for review September 21, 2026 07:11

Copilot AI review requested due to automatic review settings September 21, 2026 07:11

Copilot started reviewing on behalf of hermet September 21, 2026 07:11 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 21, 2026 07:24

Nor-s force-pushed the nor-s/conic branch from 55d113b to 6b587ab Compare September 21, 2026 07:24

Copilot started reviewing on behalf of Nor-s September 21, 2026 07:25 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 21, 2026 07:49

Nor-s force-pushed the nor-s/conic branch from 6b587ab to 6d7c0c1 Compare September 21, 2026 07:49

Copilot started reviewing on behalf of Nor-s September 21, 2026 07:50 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

hermet reviewed Sep 21, 2026

View reviewed changes

Comment thread src/ConicGradient.cpp Outdated

Comment thread src/ConicGradient.cpp Outdated

Comment thread src/ConicGradient.cpp Outdated

ConicGradient: add conic sample

cc821d2

- Port the RadialGradient example to demonstrate conic gradients. - Press Space to inspect the seam and verify the rendering quality. Issue: thorvg/thorvg#4347

Copilot AI review requested due to automatic review settings September 21, 2026 20:03

Nor-s force-pushed the nor-s/conic branch from 6d7c0c1 to cc821d2 Compare September 21, 2026 20:03

Copilot started reviewing on behalf of Nor-s September 21, 2026 20:03 View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Uh oh!

Conversation

Nor-s commented Aug 24, 2026

Screenshot

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

hermet commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hermet commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Nor-s commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

hermet commented Sep 21, 2026

Uh oh!

Nor-s commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

hermet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hermet commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nor-s commented Sep 21, 2026 •

edited

Loading