topology2: kpb: add default KPB_BUFF_TIME_MS to common_definitions - #11145
Open
naveen-manohar wants to merge 1 commit into
Open
topology2: kpb: add default KPB_BUFF_TIME_MS to common_definitions#11145naveen-manohar wants to merge 1 commit into
naveen-manohar wants to merge 1 commit into
Conversation
Commit 6db02a1(add topology-configurable history buffer) added IncludeByKey.KPB_BUFF_TIME_MS to the kpb widget class but defined KPB_BUFF_TIME_MS in dmic-wov-multi-manifest.conf All topologies including kpb.conf fails to build with err "No variable defined for KPB_BUFF_TIME_MS" Add KPB_BUFF_TIME_MS "none" to common_definitions.conf that is included before kpb.conf in all affected topologies. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
requested review from
jsarha,
lgirdwood and
singalsu
and
a lite review from Copilot
and removed request for
jsarha and
ranj063
September 1, 2026 03:16
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a default KPB_BUFF_TIME_MS definition to the shared topology2 common definitions so that any topology including kpb.conf no longer fails preprocessing with “No variable defined for KPB_BUFF_TIME_MS” unless explicitly overridden by a manifest/topology.
Changes:
- Define
KPB_BUFF_TIME_MSas"none"incommon_definitions.confto provide a safe default for KPB history-buffer configuration. - Preserve the ability for manifest/topology files (e.g.,
dmic-wov-multi-manifest.conf) to overrideKPB_BUFF_TIME_MSwith a supported value (e.g.,"6000").
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR 11145: test resultsRun date: 2026-09-01 07:56 UTC Tested commit: d224b4cc1e9ac01788e7d76d5f56b76058f4d3ca
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6db02a1(add topology-configurable history buffer) adds
IncludeByKey.KPB_BUFF_TIME_MS to kpb widget class but defined
KPB_BUFF_TIME_MS in dmic-wov-multi-manifest.conf
All topologies including kpb.conf fails to build with err
"No variable defined for KPB_BUFF_TIME_MS"
Add KPB_BUFF_TIME_MS "none" to common_definitions.conf that's
included before kpb.conf in all affected topologies.