-
Notifications
You must be signed in to change notification settings - Fork 369
boards: intel_adsp: enable coredump for all Intel targets #11134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,6 +174,24 @@ config LOG_TIMESTAMP_64BIT | |
| config ZTEST | ||
| default SOF_BOOT_TEST_SUPPORTED && SOF_BOOT_TEST_ALLOWED | ||
|
|
||
| # Zephyr / core dump | ||
| # ---------------------------------------- | ||
| # Enable core dump on all Intel ADSP targets, not just the debug (-d) build, | ||
| # so that firmware crashes can always be analysed offline. | ||
| # | ||
| # DEBUG_COREDUMP has no in-tree default, so configdefault is used to force it | ||
| # on without weakening its "depends on ARCH_SUPPORTS_COREDUMP" dependency | ||
| # (SOC_FAMILY_INTEL_ADSP selects ARCH_SUPPORTS_COREDUMP). | ||
| # | ||
| # The coredump backend and memory-dump amount are Kconfig 'choice' symbols | ||
| # with an in-tree default. As noted above, this defconfig is sourced after the | ||
| # Zephyr tree, so choice defaults cannot be overridden from here; the ADSP | ||
| # memory-window backend and minimal dump are therefore selected in each Intel | ||
| # board .conf file instead. | ||
|
|
||
| configdefault DEBUG_COREDUMP | ||
| default y | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would only do this with a west update containing zephyrproject-rtos/zephyr#117310 Without that you will not see the coredump likely in kernel and as a plus it will corrupt the mtrace print, leaving you w/o any core dump.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or flip the INTEL_ADSP_DEBUG_SLOT_MANAGER to n is another option if we are in hurry.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ujfalusi Zephyr PR now merged. Good for you ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this PR needs to be coupled w/ a west update, then yes. |
||
|
|
||
| # Zephyr / debug slot manager | ||
| # ---------------------------------------- | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app/ is obvious from the context, so I'd say no need to change.