[DNM] acp_7_x: enable ACP DMA log backend - #11089
Conversation
|
This is a gentle reminder regarding the PR review request. Please take a look when you have a chance. |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@DINESHKUMARK1 just one open, rest LGTM. Btw, the interrupt mapping should come from Zephyr
| CONFIG_SOF_LOG_LEVEL_ERR=n | ||
| CONFIG_SOF_LOG_LEVEL_WRN=n | ||
| CONFIG_SOF_LOG_LEVEL_INF=y |
There was a problem hiding this comment.
you probably want y for ERR and WRN
There was a problem hiding this comment.
We have already raised a PR in Zephyr for this. Once it is merged, we will update the corresponding follow-up PRs accordingly.
There was a problem hiding this comment.
@DINESHKUMARK1 Zephyr PR merged, we can get this in for v2.15 if we are quick.
There was a problem hiding this comment.
Updated the required changes. Please review and let me know if any further modifications are needed. Please take a look when you have a chance.
86ace75 to
820b5b7
Compare
Move the host to DSP software (IPC) interrupt from EXT_LEVEL3 to EXT_LEVEL5 so the ACP DMA log backend can own EXT_LEVEL3 for its DMA completion interrupt without colliding with IPC. Update the IPC handler registration and the PLATFORM_IPC_INTERRUPT definition accordingly, and fix a comment typo. Signed-off-by: DineshKumar Kalva <DineshKumar.Kalva@amd.com>
Enable CONFIG_LOG_BACKEND_ACP on the ACP 7.X ADSP board and the firmware logs are streamed to the host over ACP DMA. Set the SOF log level to INF explicitly, as the SOF log level configuration must be selected explicitly. Signed-off-by: DineshKumar Kalva <DineshKumar.Kalva@amd.com>
820b5b7 to
48d3803
Compare
2 participants
Enable the AMD ACP DMA logging backend on the ACP 7.X ADSP board so
firmware logs are streamed to the host over ACP DMA.
Changes:
EXT_LEVEL3 for the log DMA completion interrupt
and INF log level
Dependencies / merge order:
Also requires the Zephyr backend support from
zephyrproject-rtos/zephyr#116146 (and the SOF west manifest pointing at a
Zephyr revision that includes it), since this board config selects
CONFIG_LOG_BACKEND_ACP.
Do not merge before #11082.