Handle WoV phrase detection notification and kcontrols - #5903
Open
naveen-manohar wants to merge 2 commits into
Open
Handle WoV phrase detection notification and kcontrols#5903naveen-manohar wants to merge 2 commits into
naveen-manohar wants to merge 2 commits into
Conversation
naveen-manohar
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
lyakh,
plbossart,
ranj063 and
ujfalusi
as code owners
August 29, 2026 05:27
naveen-manohar
force-pushed
the
ww356_wov-kcontrol
branch
from
August 31, 2026 04:10
54c39e0 to
412f4a9
Compare
Member
|
@jsarha pls review - it may be that your IPC4 wov wakeup PR overlaps here. |
jsarha
requested changes
Aug 31, 2026
jsarha
left a comment
jsarha
left a comment
Collaborator
There was a problem hiding this comment.
I think it would be best to use snd_sof_pcm_period_elapsed(), but other than that I do not see anything alarming here. Of course the final judge is, does it work?
naveen-manohar
force-pushed
the
ww356_wov-kcontrol
branch
from
September 1, 2026 04:08
412f4a9 to
85f6bee
Compare
Author
Done !! |
There was a problem hiding this comment.
Pull request overview
Adds IPC4 Wake-on-Voice (WoV) phrase detection handling to the SOF driver so firmware keyword events can wake the system, notify user-space via kcontrol events, and unblock the WoV capture stream.
Changes:
- Add a new IPC4 notification handler for
SOF_IPC4_NOTIFY_PHRASE_DETECTED. - Introduce IPC4 WoV helper implementation to notify topology-defined kcontrols and trigger capture progress.
- Hook the new code into the SOF IPC4 build and notification dispatch path.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sound/soc/sof/Makefile | Adds ipc4-wov.o to the IPC4 build. |
| sound/soc/sof/ipc4.c | Dispatches PHRASE_DETECTED notifications to the WoV handler. |
| sound/soc/sof/ipc4-wov.h | Declares the WoV phrase-detected handler API. |
| sound/soc/sof/ipc4-wov.c | Implements kcontrol notifications and capture unblocking on phrase detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+13
to
+17
| /* IPC4 PHRASE_DETECTED primary/extension field layout */ | ||
| #define SOF_IPC4_PHRASE_WORD_ID_MASK GENMASK(31, 24) | ||
| #define SOF_IPC4_PHRASE_WORD_ID_SHIFT 24 | ||
| #define SOF_IPC4_PHRASE_SV_SCORE_MASK GENMASK(15, 0) | ||
|
|
Comment on lines
+89
to
+92
| list_for_each_entry(spcm, &sdev->pcm_list, list) { | ||
| if (spcm->pcm.pcm_id != SOF_WOV_PCM_ID) | ||
| continue; | ||
|
|
Add SOF_IPC4_NOTIFY_PHRASE_DETECTED notification handler, sent by DSP FW when a keyword is detected by WoV pipeline. Handler parses PCM list to find WoV capture PCM pcm_id 11, calls snd_sof_pcm_period_elapsed() to unblock waiting capture stream. Signed-off-by: Naveen Manohar <naveen.m@intel.com>
When DSP reports keyword detection, notify topology-defined WoV kcontrols so that user space can poll for value changes. Checked for 2 kcontrols in loaded topology: - 'wov_trigger_id': RO enum reporting winner slot(0/1/2) - 'wov_event': control that user space polls via POLLPRI Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
force-pushed
the
ww356_wov-kcontrol
branch
from
September 1, 2026 04:43
85f6bee to
a9f3678
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
sound/soc/sof/ipc4-wov.c:105
- The "PCM not found" warning can become noisy if firmware reports phrase detections while the WoV topology/PCM isn't present. Consider making this warning ratelimited to avoid log spam.
dev_warn(sdev->dev, "WoV: PHRASE_DETECTED but PCM %d not found\n",
SOF_WOV_PCM_ID);
Comment on lines
+18
to
+20
| /* PCM ID for WoV keyword detection capture stream */ | ||
| #define SOF_WOV_PCM_ID 11 | ||
|
|
Comment on lines
+94
to
+98
| if (!substream || !substream->runtime) { | ||
| dev_warn(sdev->dev, "WoV: PCM %d not open\n", | ||
| SOF_WOV_PCM_ID); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SOF_IPC4_NOTIFY_PHRASE_DETECTED notification handler for WoV.
When DSP FW reports keyword detection, unblock the WoV capture stream
via snd_pcm_period_elapsed()
Notify topology-defined kcontrols ('wov_trigger_id', 'wov_event') for userspace polling.
V2: snd_pcm_period_elapsed -> snd_sof_pcm_period_elapsed, word_id bit correction