fix: Pass the port of the test container on to EventSourcingDB. - #265
Merged
Merged
Conversation
with_port changed the port that is mapped and probed, but EventSourcingDB kept listening on its default port 3000, so a container with a custom port never became ready. The port is now passed on via --http-port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TCdPte6nY6ToUVd2prb9GM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_portchanged the port that the container maps and probes, but EventSourcingDB itself kept listening on its default port 3000. So a container with a custom port never became ready, andstartfailed withService failed to become ready within 20 seconds.The container now passes the port on to EventSourcingDB via
--http-port. A new test starts a container on port 4000 and pings it; without the fix it fails exactly as described above. The same fix is being made in all SDKs.🤖 Generated with Claude Code
https://claude.ai/code/session_01TCdPte6nY6ToUVd2prb9GM