fix: Describe the signing key of the test container as what it is. - #407
Merged
Merged
Conversation
The README said that the signing key can be used when configuring the container to sign outgoing events, which the SDK does not offer. It is the private key EventSourcingDB signs events with. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VVZx93wLHrp5dyCWKjUAfd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said that the signing key can be used when configuring the container to sign outgoing events, which the SDK does not offer. It now describes the signing key as what it is: the private key EventSourcingDB signs events with. The same wording is used in all SDKs now.
This is a fix, so that the registry shows the corrected README, too.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VVZx93wLHrp5dyCWKjUAfd