🚀 Instructor dashboard concurrent ajax lazyloading & zero-cls skeletons - #2985
Open
b-l-i-n-d wants to merge 9 commits into
Open
🚀 Instructor dashboard concurrent ajax lazyloading & zero-cls skeletons#2985b-l-i-n-d wants to merge 9 commits into
b-l-i-n-d wants to merge 9 commits into
Conversation
…ing and adapter pattern
b-l-i-n-d
changed the title
shewa12
reviewed
Sep 2, 2026
| ); | ||
|
|
||
| try { | ||
| $result = self::render_section( $section_id, $params ); |
Collaborator
There was a problem hiding this comment.
This method is not throwing an exception. Try-catch is not useful here.
shewa12
reviewed
Sep 2, 2026
| * @since 4.0.9 | ||
| */ | ||
| protected static function render_current_stats( $data, array $params ): array { | ||
| $start_date = $params['start_date'] ?? ''; |
Collaborator
There was a problem hiding this comment.
How are we sanitizing the data?
shewa12
reviewed
Sep 2, 2026
| * @param array $params Context parameters. | ||
| * @return array | ||
| * | ||
| * @since 4.0.9 |
Collaborator
There was a problem hiding this comment.
Check all the docs comments, the format is not what we use. @SInCE tag should on top of param, one line gap should be added before any different annotation.
shewa12
reviewed
Sep 2, 2026
| * @since 4.0.9 | ||
| */ | ||
| public static function date_range( string $from, string $to ): array { | ||
| return array( |
b-l-i-n-d
added
4.0.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstructorMetricsAdapterto decouple domain metrics calculations from presentationDashboardSectionManagerto handle dashboard section dispatching, hooks, and AJAX endpointstutorLazySectionAlpine component with query caching, error toasts, and visibility observersTUTOR_CUSTOM_EVENTS) across date filter and sorting listenerstop_performing_course0001-dashboard-ajax-lazyloading-architecture.md,0002-dashboard-metrics-adapter-pattern.md)