Repository navigation
feat: node-redis instrumentation; Prisma, Sequelize, Knex, node-redis in the driver matrix - #22
Merged
Merged
Conversation
…dis in the driver matrix - instrumentNodeRedis for redis / @redis/client 4 and 5 (MULTI and pipeline commands tracked one by one), auto target 'redis' - sqlLabel: CREATE/DROP TABLE IF [NOT] EXISTS are labelled by table - test/compat: redis 4/5, Prisma 5/6 on SQLite (prisma-setup.js), Sequelize 6 and Knex 2/3 on pg and mysql2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentNodeRedis(tp, require('redis'))for node-redis 4 and 5 (redis GET; MULTI and pipeline commands tracked one by one); auto-instrumented as theredistarget (also@redis/client). v4 legacyMode is not covered.sqlLabel:CREATE TABLE IF NOT EXISTS "Users"(Sequelizesync()) wasCREATE IF, nowCREATE Users; same forDROP TABLE IF EXISTS.prisma-setup.js), Sequelize 6 and Knex 2/3 on pg and mysql2, exact-label assertions. Prisma 7 skipped: SQLite needs a driver adapter + TS-only generator.