Repository navigation
fix(storybook): drop downlevelIteration removed in TypeScript 7 - #790
Merged
Merged
Conversation
TypeScript 7.0.2 removed the option, so tsc aborted with TS5102 before it checked anything, failing storybook#typecheck. The option was already dead weight here: it only ever affected emit for targets below ES2015, and this config sets target ESNext with noEmit.
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storybook#typecheckhas been failing, which also failspnpm turbo:checkand CI:apps/storybook resolves
typescript@7.0.2, which removed the option.tsctreats it as a config error and aborts before checking anything, so the whole task fails on one dead setting.The change
One line removed from
apps/storybook/tsconfig.json. The option was already doing nothing here:downlevelIterationonly ever affected emit for targets below ES2015, and this config sets"target": "ESNext"with"noEmit": true.No source files needed changes, and
pnpm-lock.yamlis untouched.Verification
pnpm --filter storybook typecheckexits clean. Because the config error previously aborted the run, this is the first time storybook source is actually checked under TS 7, and no masked type errors surfaced.pnpm turbo:checkfrom the repo root: 8 successful, 8 total.tscnow reports no diagnostics at all, so nothing else in that tsconfig is removed or deprecated under TS 7.listEmittedFilesandstrictFunctionTypesare left alone to keep this minimal.