Skip to content

Add initial implementation of Math Game with game logic and configuration - #791

Closed
engapantio wants to merge 1 commit into
the-csharp-academy:mainfrom
engapantio:main
Closed

engapantio wants to merge 1 commit into
the-csharp-academy:mainfrom
engapantio:main

Conversation

@engapantio

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@engapantio Project approved! 😄✅ And well done for completing the challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work!

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ Consider clearing the console more often as your UI is getting cluttered pretty quickly.

🔍️Small detail but when validating answers, entering a non-numeric answer counts as an incorrect question. You could instead repeat the input prompt until a valid integer is entered.

🔍For the divisions, your current implementation works, but generating an array of possible divisors for every division question introduces unnecessary allocations.

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants