Make the status-bar Todos button toggle back to All - #49
Open
aguspatur22 wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "fix/issue-27-ux-\u9876\u680f\u6309\u94ae\u9ad8\u5ea6\u4e0d\u7edf\u4e00--\u5f85\u529e\u7b5b\u9009\u96be\u4ee5\u6062\u590d\u5230\u5168\u90e8"
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking Todos in the bottom status bar sets the memo list filter to todos, but there's no way back from that entry point. The only way to return to All is the separate filter dropdown at the top of the memo list, which is a few clicks away and isn't obvious from the status bar itself.
handleOpenTodos in main-layout.tsx now toggles: clicking again while already on todos switches the filter back to all, using the same setActiveFilter/loadMemos flow it already had.
Fixes half of #27 — the titlebar button height part of that issue was already fixed in v1.0.8, this covers the remaining toggle request.
No test file covers main-layout.tsx yet and the component pulls in a lot of Zustand store wiring, so I checked this by hand: tsc --noEmit is clean, and vitest run shows the same failing/passing counts with and without the change (some pre-existing localStorage mock failures unrelated to this file).