Skip to content

fix: apply withStartupTimeout() to the port-binding pre-wait #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenzox wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: apply withStartupTimeout() to the port-binding pre-wait #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/testcontainers/src/generic-container/generic-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ export class GenericContainer implements TestContainer {
if (!inspectResult.State.Running) {
log.debug("Reused container is not running, attempting to start it");
await client.container.start(container);
inspectResult = await inspectContainerUntilPortsExposed(() => client.container.inspect(container), container.id);
inspectResult = await inspectContainerUntilPortsExposed(
() => client.container.inspect(container),
container.id,
this.startupTimeoutMs
);
}

const mappedInspectResult = mapInspectResult(inspectResult);
Expand Down Expand Up @@ -217,7 +221,8 @@ export class GenericContainer implements TestContainer {

const inspectResult = await inspectContainerUntilPortsExposed(
() => client.container.inspect(container),
container.id
container.id,
this.startupTimeoutMs

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a regression test for the timeout path

This bug fix changes GenericContainer.start() behavior, but there is no test proving that a custom withStartupTimeout() lets the port-binding pre-wait run past the utility's 10s default; a future refactor could silently reintroduce the cap. Please add a focused regression test around this startup path that fails before the change and passes after it.

AGENTS.md reference: AGENTS.md:L29-L34

Useful? React with 👍 / 👎.

);
const mappedInspectResult = mapInspectResult(inspectResult);
const boundPorts = BoundPorts.fromInspectResult(client.info.containerRuntime.hostIps, mappedInspectResult).filter(
Expand Down