Skip to content

Fix CockroachDB SCRAM iteration limit - #11999

Open
skrcode wants to merge 1 commit into
testcontainers:dependabot/gradle/modules/cockroachdb/org.postgresql-postgresql-42.7.12from
skrcode:jaipilot/cockroach-scram-iterations
Open

Fix CockroachDB SCRAM iteration limit#11999
skrcode wants to merge 1 commit into
testcontainers:dependabot/gradle/modules/cockroachdb/org.postgresql-postgresql-42.7.12from
skrcode:jaipilot/cockroach-scram-iterations

Conversation

@skrcode

@skrcode skrcode commented Aug 28, 2026

Copy link
Copy Markdown

Companion fix for #11879.

pgJDBC 42.7.12 adds a secure default cap of 100,000 SCRAM PBKDF2 iterations. CockroachDB v22.2 requests exactly 119,680, so the module’s runtime tests now fail with the driver’s explicit instruction to raise scramMaxIterations.

This sets a bounded default of 119,680 in both the current and deprecated Cockroach container APIs. It preserves pgJDBC’s protection rather than disabling it, and callers can still override the value through the existing URL-parameter map. The integration test now asserts that the generated JDBC URL contains the compatibility setting.

Verification:

  • :testcontainers-cockroachdb:compileJava passed
  • :testcontainers-cockroachdb:compileTestJava passed
  • :testcontainers-cockroachdb:checkstyleMain passed
  • :testcontainers-cockroachdb:checkstyleTest passed
  • 13 Gradle tasks completed successfully
  • git diff --check

The source PR’s CI reproduces the runtime failure three times against CockroachDB with the exact 119,680-versus-100,000 diagnostic. A post-fix runtime rerun was not available locally because Docker is not running, so no runtime pass is claimed. spotlessCheck was also attempted but blocked before source checking by a stale global Equo P2 cache lock; that user cache was left untouched.

@skrcode
skrcode requested a review from a team as a code owner August 28, 2026 15:59
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: afc91516-a9a6-4297-b5c9-695767899653

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant