Skip to content

shipping: define local review fallback for stuck artifact-free webhook reviews #35

Description

@teslamint

Problem

Cogvault PR #34 had an external webhook review stuck in progress for over seven hours without review artifacts. A local CodeRabbit CLI review produced findings in under two minutes.

The existing skipped-review guidance does not define a standing fallback for this state.

Requested change

Define a bounded fallback in the shipping workflow for a required external review that remains in progress without artifacts.

Acceptance criteria

  • Distinguish stuck, skipped, failed, and completed reviews using artifacts and execution state.
  • Define a bounded wait and an explicit transition to a supported local reviewer.
  • Retain the reviewed revision, command, completion result, findings, and their dispositions.
  • Invalidate stale review evidence when the reviewed change changes.
  • Never treat a timeout or fallback failure as a waiver or completed review.
  • Add workflow regression coverage for successful fallback, unavailable CLI, incomplete review, and changed revision.

Evidence and scope

Compound-loop owns the reusable workflow. Cogvault retains the originating evidence. This issue does not request changes to Cogvault runtime code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions