Skip to content

[Snyk] Security upgrade sh from 1.14.1 to 2.2.4#31

Open
mandibles232 wants to merge 1 commit into
masterfrom
snyk-fix-e3a43b3882a0945fab2712d0536f38fc
Open

[Snyk] Security upgrade sh from 1.14.1 to 2.2.4#31
mandibles232 wants to merge 1 commit into
masterfrom
snyk-fix-e3a43b3882a0945fab2712d0536f38fc

Conversation

@mandibles232

Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • requirements.txt
⚠️ Warning
matplotlib 3.3.3 requires numpy, which is not installed.

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-SH-18017924
@mandibles232

Copy link
Copy Markdown
Author

Merge Risk: High

The upgrade from sh v1 to v2 is a major version with significant breaking changes that require code modifications and environment updates.

Key Breaking Changes in v2.0.0:

  • Python Version: Support for Python versions older than 3.8 has been dropped.
  • Default Output Type: Executed commands now return a unicode string by default, instead of bytes. Code that expects byte strings and performs byte-specific operations will need to be updated.
  • Piping with RunningCommand: Passing a RunningCommand object as the first argument to a command no longer automatically pipes its output as stdin. This will break command chains that relied on this implicit behavior.
  • Removed Features:
    • "Magical module-like execution contexts" have been removed.
    • The built-in cd command override has been removed.
    • The __eq__ method on a RunningCommand no longer executes the command as a side effect.

Recommendation: This upgrade requires careful code review and testing. Developers must verify that their environment uses Python 3.8+ and update all call sites to handle unicode string output. Any code using the removed features or implicit stdin piping must be refactored.

Source: GitHub Changelog

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants