Repository navigation
feat(notifications): localise the rest of the push text (#1037) - #1043
Merged
Merged
Conversation
Follow-up to #1041. Celebration messages, recap announcements (and their period labels), month and weekday names in the monthly report, season champion and auction dates, name lists ("A, B and C") and the panel's test-push sample names now follow HA's language too. Strings are loaded at startup and reloaded when HA's language changes, so text built outside the dispatcher is translated as well. A test push now fills {date}, {max_points}, {result_text} and {freezes_left}, which were previously sent as literal placeholders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1037. Follow-up to #1041: the rest of the push notification text now follows Home Assistant's language.
Newly localised
taskmate_celebrationeventmessage, so TTS automations speak them in your language too.Jul–Sep).So, 4. Okt).Fixes along the way
{date},{max_points},{result_text}and{freezes_left}. They are filled now.core_config_updated, so changing HA's language takes effect without a restart. Text built outside the dispatcher (celebrations, recaps) no longer depends on a push having gone out first..capitalize()the label. That turnedJul–SepintoJul–sepand would mis-capitalise other languages. The English parent message now reads "✨ New September recaps are ready for …".Non-English recap templates put the period in brackets ("Dein Rückblick ist fertig (September)"), so a week, month, year or range all read naturally.
Translations
da, de, fr, nb, nn, pl, pt, pt-BR. German month names that match English ("April", "September" …) and pure format patterns are allow-listed in
locale_english_baseline.json.Tests
{placeholder}and (outside English) no English sample names. Also German dates / months / name lists / recap labels, English fallbacks, and a language change reloading the strings.