Skip to content

Move Cloud Run to public preview - #3945

Open
rossnelson wants to merge 1 commit into
mainfrom
feat/cloud-run-public-preview
Open

rossnelson wants to merge 1 commit into
mainfrom
feat/cloud-run-public-preview

Conversation

@rossnelson

@rossnelson rossnelson commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Cloud Run has carried a Pre-release badge since it was added. It is going to public preview, so the shared default release stage now says so, putting it alongside Lambda.

 export const defaultReleaseStage: Record<...> = {
   lambda: 'public-preview',
   agentcore: 'pre-release',
-  'cloud-run': 'pre-release',
+  'cloud-run': 'public-preview',
 };

This is the badge only. It does not change which providers a caller is offered: self-hosted already offers all three, and Temporal Cloud decides its own list before handing it to the picker.

Why it has to be here

compute-provider-picker.svelte resolves the stage as option.releaseStage ?? defaultReleaseStage[option.value]. A consumer that passes no releaseStage falls through to this default, and none pass one — so this is the only place the badge can be changed.

Consumers pick it up when they next update this package.

Testing 🧪

How was this tested 👻

  • Unit tests pass
  • Storybook coverage added

The badge now carries its stage

Badge gets data-release-stage, so a test can assert the stage rather than the words rendered for it:

<Badge size="sm" text={releaseStageLabel(option)} data-release-stage={releaseStageOf(option)} />

The stage is the stable fact; the label is copy — and this PR is itself an example of that copy moving. A test pinned to getByText('Pre-release') would have failed here for a reason that has nothing to do with what it was checking.

The stories assert the attribute now, including the two that already read rendered text:

const stage = canvasElement
  .querySelector('[data-release-stage]')
  ?.getAttribute('data-release-stage');
await expect(stage).toBe('public-preview');

Core matchers only (toBe, toEqual, and the toBeInTheDocument already in use) — no jest-dom matcher that nothing else in the repo relies on.

A new story covers the shape a consumer renders for a GCP namespace: AWS providers hidden, no explicit releaseStage, so the assertion reads the shared default rather than a caller override. The existing "Release stage overridden by caller" story still passes an explicit pre-release, so it keeps proving a caller can override the default in either direction.

Chromatic will show diffs on the stories where Cloud Run's badge changes. That is the intended change.

Checklists

Merge Checklist

  • Verified this is the only source of Cloud Run's badge

Issue(s) closed

None — part of the Cloud Run public preview rollout.

@rossnelson
rossnelson requested a review from a team as a code owner September 19, 2026 17:53
@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Sep 19, 2026 10:39pm UTC

Request Review

Cloud Run has been behind a pre-release badge since it was added. It is
going to public preview, so the shared default release stage now says so,
putting it alongside Lambda.

This is the badge only. It does not change which providers a caller is
offered: self-hosted already offers all three, and a consumer that
restricts the list decides its own before handing it to the picker.

The badge also carries its stage as a data attribute now, so a test can
assert the stage rather than the words rendered for it. The stage is the
stable fact; the label is copy, and this change is itself an example of
that copy moving. The stories assert the attribute, including the two
that already read the rendered text.

Adds a story for the shape a consumer renders for a GCP namespace, with
the AWS providers hidden and no explicit releaseStage, so the assertion
reads the shared default rather than a caller override.

This branch was successfully deployed

1 active deployment
Preview 4dedc31c Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant