Move Cloud Run to public preview - #3945
Open
rossnelson wants to merge 1 commit into
Open
rossnelson wants to merge 1 commit into
rossnelson wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
Cloud Run has been behind a pre-release badge since it was added. It is going to public preview, so the shared default release stage now says so, putting it alongside Lambda. This is the badge only. It does not change which providers a caller is offered: self-hosted already offers all three, and a consumer that restricts the list decides its own before handing it to the picker. The badge also carries its stage as a data attribute now, so a test can assert the stage rather than the words rendered for it. The stage is the stable fact; the label is copy, and this change is itself an example of that copy moving. The stories assert the attribute, including the two that already read the rendered text. Adds a story for the shape a consumer renders for a GCP namespace, with the AWS providers hidden and no explicit releaseStage, so the assertion reads the shared default rather than a caller override.
rossnelson
force-pushed
the
feat/cloud-run-public-preview
branch
from
September 19, 2026 22:38
b6aea5a to
4dedc31
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Cloud Run has carried a Pre-release badge since it was added. It is going to public preview, so the shared default release stage now says so, putting it alongside Lambda.
export const defaultReleaseStage: Record<...> = { lambda: 'public-preview', agentcore: 'pre-release', - 'cloud-run': 'pre-release', + 'cloud-run': 'public-preview', };This is the badge only. It does not change which providers a caller is offered: self-hosted already offers all three, and Temporal Cloud decides its own list before handing it to the picker.
Why it has to be here
compute-provider-picker.svelteresolves the stage asoption.releaseStage ?? defaultReleaseStage[option.value]. A consumer that passes noreleaseStagefalls through to this default, and none pass one — so this is the only place the badge can be changed.Consumers pick it up when they next update this package.
Testing 🧪
How was this tested 👻
The badge now carries its stage
Badgegetsdata-release-stage, so a test can assert the stage rather than the words rendered for it:The stage is the stable fact; the label is copy — and this PR is itself an example of that copy moving. A test pinned to
getByText('Pre-release')would have failed here for a reason that has nothing to do with what it was checking.The stories assert the attribute now, including the two that already read rendered text:
Core matchers only (
toBe,toEqual, and thetoBeInTheDocumentalready in use) — no jest-dom matcher that nothing else in the repo relies on.A new story covers the shape a consumer renders for a GCP namespace: AWS providers hidden, no explicit
releaseStage, so the assertion reads the shared default rather than a caller override. The existing "Release stage overridden by caller" story still passes an explicitpre-release, so it keeps proving a caller can override the default in either direction.Chromatic will show diffs on the stories where Cloud Run's badge changes. That is the intended change.
Checklists
Merge Checklist
Issue(s) closed
None — part of the Cloud Run public preview rollout.