clean up todo comments of time skipping - #12046
Merged
Merged
Conversation
feiyang3cat
commented
Sep 13, 2026
| ) | ||
| } | ||
|
|
||
| if s.executionInfo.GetTimeSkippingInfo() != nil { |
Contributor
Author
There was a problem hiding this comment.
this executionInfo is a fresh one and always have nil timeSkippingInfo
the scenarios we need to wrap time source
- when an execution is loaded from DB -> NewMutableStateFromDB
- when a new child/next run has initial skipped duration propagated ->
- func (t *transferQueueActiveTaskExecutor) startChildWorkflow
- func NewMutableStateInChain(
- when an execution has time skipping enabled at start time
- when an execution has time skipping enabled in the middle of its execution
-> both 3&4 ApplyWorkflowExecutionOptionsUpdatedEvent → TimeSkippingInfo == nil → initTimeSkippingInfo → wrapTimeSourceWithTimeSkipping
simvlad
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
wrapTimeSourceWithTimeSkippingin passive clusterWhy?
when those features were added, todo comments are not delete together
How did you test it?
`