testing branch - #12031
Open
davidporter-id-au wants to merge 1 commit into
Open
testing branch#12031davidporter-id-au wants to merge 1 commit into
davidporter-id-au wants to merge 1 commit into
Conversation
Contributor
|
Claude finished @davidporter-id-au's task in 32s —— View job Reviewed 1 file, 1 finding. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ############################# Main targets ############################# | ||
| # Install all tools and builds binaries. | ||
| install: bins | ||
| # test |
Contributor
There was a problem hiding this comment.
Stray marker left over from testing — it carries no information and doesn't follow the file's convention of placing a descriptive comment above the target it documents. Sitting directly under install: bins, it reads as if it were part of the install rule.
Functionally it's inert (Make ignores comment lines, and install still has no recipe), so there's no build impact, but it shouldn't land on release/v1.30.x.
Suggested change
| # test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.