Skip to content

[SDK Sentinel] Fix time-skipping external cancel test race #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tconley1428 merged 1 commit into from
Oct 28, 2026
+8 −6
Merged

[SDK Sentinel] Fix time-skipping external cancel test race #2027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,21 +2029,23 @@ async def run(self, external_workflow_id: str) -> None:


async def test_workflow_cancel_external(client: Client):
async with new_worker(client, CancelExternalWorkflow, LongSleepWorkflow) as worker:
# Start long sleep, then cancel and check that it got cancelled
long_sleep_handle = await client.start_workflow(
LongSleepWorkflow.run,
async with new_worker(
client, CancelExternalWorkflow, WaitForeverWorkflow
) as worker:
# A timer can finish under time skipping before the external cancel is sent.
target_handle = await client.start_workflow(
WaitForeverWorkflow.run,
id=f"workflow-{uuid.uuid4()}",
task_queue=worker.task_queue,
)
await client.execute_workflow(
CancelExternalWorkflow.run,
long_sleep_handle.id,
target_handle.id,
id=f"workflow-{uuid.uuid4()}",
task_queue=worker.task_queue,
)
with pytest.raises(WorkflowFailureError) as err:
await long_sleep_handle.result()
await target_handle.result()
assert isinstance(err.value.cause, CancelledError)


Expand Down
Loading