Skip to content

Raise the dev server's default workflow task timeout in tests #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DABH wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −2
Draft

Raise the dev server's default workflow task timeout in tests #1845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cacf57f
Raise the dev server's default workflow task timeout in tests
DABH Sep 10, 2026
25a9d03
Expect the 60s task timeout default only on the local dev server
DABH Sep 10, 2026
17f7ed6
Merge remote-tracking branch 'origin/main' into flake/default-wft-tim…
DABH Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,9 @@ async def env(env_type: str) -> AsyncGenerator[WorkflowEnvironment, None]:
dev_server_extra_args=[
"--dynamic-config-value",
"system.forceSearchAttributesCacheRefreshOnRead=true",
# Keep a stalled first workflow task from timing out and retrying on slow CI
"--dynamic-config-value",
'history.defaultWorkflowTaskTimeout="60s"',
"--dynamic-config-value",
f"limit.historyCount.suggestContinueAsNew={CONTINUE_AS_NEW_SUGGEST_HISTORY_COUNT}",
"--dynamic-config-value",
Expand Down
5 changes: 3 additions & 2 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ async def run(self) -> dict:
return json.loads(json.dumps(ret, default=str))


async def test_workflow_info(client: Client, env: WorkflowEnvironment):
async def test_workflow_info(client: Client, env: WorkflowEnvironment, env_type: str):
# TODO(cretz): Fix
if env.supports_time_skipping:
pytest.skip(
Expand Down Expand Up @@ -258,7 +258,8 @@ async def test_workflow_info(client: Client, env: WorkflowEnvironment):
assert uuid.UUID(info["run_id"]).version == 7
assert info["run_timeout"] is None
assert info["task_queue"] == worker.task_queue
assert info["task_timeout"] == "0:00:10"
# Only the local dev server gets the 60s default from tests/conftest.py
assert info["task_timeout"] == ("0:01:00" if env_type == "local" else "0:00:10")
assert info["workflow_id"] == workflow_id
assert info["workflow_type"] == "InfoWorkflow"

Expand Down
Loading