Skip to content

Use retrying client for worker deployment RPCs in tests #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DABH wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use retrying client for worker deployment RPCs in tests #1829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cccbaf8
Use retrying client for worker deployment RPCs in tests
DABH Sep 10, 2026
5cdf1c6
Merge remote-tracking branch 'origin/main' into flake/worker-deployme…
DABH Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/worker/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,7 +1281,8 @@ async def mk_call() -> DescribeWorkerDeploymentResponse:
DescribeWorkerDeploymentRequest(
namespace=client.namespace,
deployment_name=version.deployment_name,
)
),
retry=True,
)
except RPCError:
# Expected
Expand All @@ -1304,7 +1305,8 @@ async def set_current_deployment_version(
deployment_name=version.deployment_name,
version=version.to_canonical_string(),
conflict_token=conflict_token,
)
),
retry=True,
)


Expand All @@ -1321,7 +1323,8 @@ async def set_ramping_version(
version=version.to_canonical_string(),
conflict_token=conflict_token,
percentage=percentage,
)
),
retry=True,
)
return response

Expand All @@ -1341,7 +1344,8 @@ async def check() -> bool:
DescribeWorkerDeploymentRequest(
namespace=client.namespace,
deployment_name=deployment_name,
)
),
retry=True,
)
routing_config = resp.worker_deployment_info.routing_config
if (
Expand Down
Loading