Regenerate system Nexus APIs with intermediate model hooks#1656
Draft
tconley1428 wants to merge 1 commit into
Draft
Regenerate system Nexus APIs with intermediate model hooks#1656tconley1428 wants to merge 1 commit into
tconley1428 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1655. Regenerates the system Nexus workflow service API from the updated nex-gen output so operation definitions use user-facing generated models and those models expose _temporal_to_intermediate/_temporal_from_intermediate hooks.\n\nValidation:\n- env UV_CACHE_DIR=/private/tmp/nexus-api-gen-uv-cache uv run pyright temporalio/converter temporalio/nexus/system temporalio/worker/_workflow_instance.py tests/nexus/test_temporal_system_nexus.py tests/test_converter.py tests/worker/test_visitor.py\n- env UV_CACHE_DIR=/private/tmp/nexus-api-gen-cache uv run -m pytest tests/test_converter.py::test_temporal_intermediate_payload_converter_wraps_user_converter tests/nexus/test_temporal_system_nexus.py tests/worker/test_visitor.py -q