Prevent post-return activity cancel from killing pool thread#1654
Open
tconley1428 wants to merge 2 commits into
Open
Prevent post-return activity cancel from killing pool thread#1654tconley1428 wants to merge 2 commits into
tconley1428 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Fixes #1648
Validation
uv run pytest tests/worker/test_activity.py::test_sync_activity_cancel_after_return_does_not_kill_thread_pool_worker -quv run pytest tests/worker/test_activity.py::test_sync_activity_thread tests/worker/test_activity.py::test_sync_activity_contextvars tests/worker/test_activity.py::test_sync_activity_cancel_after_return_does_not_kill_thread_pool_worker -quv run pyright temporalio/worker/_activity.py tests/worker/test_activity.pyuv run ruff check tests/worker/test_activity.pyuv run ruff check --ignore E722 temporalio/worker/_activity.py tests/worker/test_activity.pyI also temporarily reverted the implementation change while keeping the regression test. The test failed and logged the expected ThreadPoolExecutor
Exception in workertraceback from an injectedtemporalio.exceptions.CancelledError, then passed again after restoring the fix.