Repository navigation
Propagate Nexus serialization context to workflow updates - #3172
Merged
JoshuaFrenchwood merged 1 commit intoOct 29, 2026
Conversation
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 27, 2026 21:02
9cb96e2 to
cee99cc
Compare
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
2 times, most recently
from
October 28, 2026 19:54
f31c42b to
67e8832
Compare
VegetarianOrc
approved these changes
Oct 29, 2026
Comment on lines
+16
to
+21
| * <p>When a handler starts a workflow, sends a workflow update or starts a standalone activity, | ||
| * this context is propagated to it through the server. They use it only for their result and | ||
| * failures, which are returned to the caller, and a standalone activity also uses it for its | ||
| * heartbeat details, which the server puts into its timeout failure. A workflow's input, memo, | ||
| * static summary and details, signals, queries and updates not sent by a handler keep the {@link | ||
| * WorkflowSerializationContext}, as do an update's arguments; a standalone activity's input and |
Contributor
There was a problem hiding this comment.
Same note as the PR underneath this one. Would be good to keep this more understandable for an end users mental model.
JoshuaFrenchwood
force-pushed
the
nexus-serialization-context-workflow-update
branch
from
October 29, 2026 20:23
67e8832 to
7e52351
Compare
JoshuaFrenchwood
deleted the
nexus-serialization-context-workflow-update
branch
October 29, 2026 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Nexus operation handlers now propagate their
NexusSerializationContextto the workflow updatesthey send.
result, failure and rejection with it, and update handles decode with the context returned on the
update and poll responses.
Why?
A Nexus handler returns the result and failure of the update it sends to the Nexus caller. The
caller decodes them with the operation's
NexusSerializationContext, so a codec keyed on thecontext couldn't decode them when they were encoded with the workflow context.
Checklist
Closes
How was this tested:
WorkflowUpdateNexusSerializationContextTest: the in-memory server sends real updates with thecontext set, covering update result, failure, rejection and replay.
NexusSerializationContextPropagationTeston the dev server: a caller workflow goesthrough a Nexus endpoint to a handler that sends a workflow update.