[SDK Sentinel] Allow activity retry delay test to complete - #3010
Merged
Conversation
Contributor
|
@sdk-sentinel-bot Remove the upper bound on the duration, count the number of attempts, and make the fallback retry policy shorter. |
sdk-sentinel-publisher Bot
pushed a commit
to sdk-sentinel-forks/sdk-java
that referenced
this pull request
Aug 25, 2026
SDK-Sentinel-Request: temporalio#3010/comment-5411842828
Contributor
Author
|
Adjusted the tests as requested: duration assertions now have no upper bound, both cases assert exactly four invocations, and the fallback retry policy starts at 100 ms. Both Java 11 CLI-backed cases and the focused formatting/test compilation check pass. Trusted validation and pinned Java 11 CLI CI remain required. Updated the PR at |
dplyukhin
marked this pull request as ready for review
August 25, 2026 15:18
dplyukhin
approved these changes
Aug 25, 2026
dplyukhin
enabled auto-merge (squash)
August 25, 2026 15:19
SDK-Sentinel-Request: temporalio#3010/comment-5411842828
yuandrew
force-pushed
the
automation/sdk-sentinel/ci-flake/java/31847451911-1-034748df6ce1
branch
from
August 25, 2026 15:33
20fc52a to
b607cca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This draft contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
The Java 11 CLI-backed suite timed out in
ActivityNextRetryDelayTest.activityNextRetryDelaywhile waiting for its workflow result ([first captured failure](https://github.com/temporalio/sdk-java/actions/runs/31753323140/job/94623675320)). No preceding equivalent success was captured. Breaking changes: none. Server PR: none.Root cause
The test intentionally requests one-, two-, and three-second retry delays but inherits a ten-second rule deadline. Service and scheduler latency stretched the first retry interval beyond five seconds, leaving too little budget for the final attempt; JUnit interrupted the history long poll.
Fix
Give this test a 30-second rule deadline. Retry behavior and the existing timing assertions remain unchanged, while transient service latency can no longer terminate the test before those assertions run.
Validation
The focused class passed on Java 11 against a loopback Temporal CLI, and an adjusted
spotlessCheck testClassespassed. Exact repository validation was attempted but the sandbox blocked writes to.git/modules; the trusted unchanged baseline passed it. The pinned CLI job and trusted patch validation remain required.Validation status:
validation-incompletehighmediummediumstandard— 1 changed file; 786 Bnot-reproduced— The unchanged focused CLI-backed class passed locally; the captured load-induced delay did not recur.pass-after-only— The existing focused Java 11 CLI-backed test passed after the test-scoped timeout change; no new test was required.Gradle formatting and test-source compilation) — passedGradle formatting and test-source compilation) — did not pass (failure)Investigator-run checks
USE_EXTERNAL_SERVICE=true TEMPORAL_SERVICE_ADDRESS=127.0.0.1:7233 ./gradlew --offline --no-daemon :temporal-sdk:test --tests 'io.temporal.activity.ActivityNextRetryDelayTest' -PtestJavaVersion=11 -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules -x :temporal-sdk:compileJava17Java -x :temporal-sdk:compileJava21Java— passed; 1 attempt(s). Both activity and local-activity cases passed on Java 11 against the loopback Temporal CLI..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Failed before candidate compilation because the sandbox denied writes to .git/modules; the trusted unchanged-checkout baseline passed the same command../gradlew --offline --no-daemon spotlessCheck testClasses -x test -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules— passed; 1 attempt(s). Formatting and test-class compilation passed when only the sandbox-blocked submodule metadata tasks were excluded.Required target CI
Residual risks
Automation provenance
7cf35351b27a3a7af17b4fadd4d281893a96580fIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-08-13 23:33 UTC2026-08-21 21:08 UTC