Update Nexus messaging samples to use Temporal Operation handler - #225
Merged
Merged
Conversation
atol
force-pushed
the
alicelin/NEXUS-696/sdk-ergonomics
branch
from
September 9, 2026 19:37
c1a2f6e to
c2a94f0
Compare
Evanthx
approved these changes
Sep 10, 2026
Evanthx
left a comment
Evanthx
left a comment
Contributor
There was a problem hiding this comment.
Looks OK, one comment but not something that needs to change in this PR!
| { | ||
| DevServerOptions = new() | ||
| { | ||
| DownloadVersion = "v1.7.4-standalone-nexus-operations", |
Contributor
There was a problem hiding this comment.
I am wondering if we should break this version out into a constant somewhere - it is in this two times, and is in the repo a few more times. But that might be better as a separate change, especially as we should do that across all the sample repos.
Contributor
There was a problem hiding this comment.
I'd be fine leaving as is for now, especially if it matches the other values. Let's refactor it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
How was this tested
Ran the samples and verified output