Sean/cloudrun public preview - #211
Draft
seanbollin wants to merge 3 commits into
Draft
Conversation
Move the sample from src/CloudRunWorker to src/Gcp/CloudRun/OpenTelemetry (and its test to tests/Gcp/CloudRun/OpenTelemetry) so the layout mirrors the merged SDK package Temporalio.Extensions.Gcp.CloudRun.OpenTelemetry and the other SDKs' Cloud Run samples, leaving room for additional Cloud Run samples (e.g. worker ID) under src/Gcp/CloudRun/. - Rename the project/namespace to TemporalioSamples.Gcp.CloudRun.OpenTelemetry (updating the .sln, the tests project reference, and the Dockerfile paths and output dll name). - Bump the Temporalio package family to 1.18.0 (the release that introduces the GCP Cloud Run OpenTelemetry package) and, as its required companion, NexusRpc to 0.4.0. The shared test project references this sample, so the whole repo must move together. - Point the temporary local-feed nuget.config at the new sample path. Verified with the merged package packed into the local feed: the full solution restores and builds at 1.18.0/NexusRpc 0.4.0, the sample emits TemporalioSamples.Gcp.CloudRun.OpenTelemetry.dll, and the test is discovered under the new namespace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sample of running a workflow in CloudRun w/ OpenTelemetry extension
What was changed
Added a CloudRun worker sample using OpenTelemetry extension
Why?
As part of CloudRun public preview we're adding an OpenTelemetry extension to the .NET SDK
Checklist
https://temporalio.atlassian.net/browse/COM-260
Deployed to Cloud Run and verified metrics were visible in Metrics Explorer
4. Any docs updates needed?