Repository navigation
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
A pinned attempt that started and then failed leaves the tool's outcome unknown, and nothing can say whether the process behind it stopped. The step is closed on the shared queue without touching the tree, so the turn goes on, and the pack store refuses files from an attempt the session has moved past, under the same token the transcript is fenced by.
moetemp
force-pushed
the
moe/pinned-queues
branch
from
September 15, 2026 01:01
012f1f5 to
ab3408a
Compare
moetemp
force-pushed
the
moe/lost-host-migration
branch
from
September 15, 2026 01:01
4a5ce71 to
2420e09
Compare
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps a turn going when a pinned attempt that had started fails.
Nothing can say whether the tool over there has stopped, so the step's calls stay where their host has them, and the step is closed on the shared queue without touching the tree: a seal standing in a directory that never ran the tools would ship the state before them. What makes the window harmless is that nobody else publishes during it, and the pack store now refuses files from an attempt the session has moved past, under the same owner token the transcript is fenced by.
Two clauses a lost host is held to are written on
SnapshotSync.push, and both have a test: the seal that closes a step elsewhere publishes nothing (stepped-drain-writers.test.ts), and a pack from a superseded attempt is refused (SnapshotSync owner fenceinworktree-materialize.test.ts).pinned-retry.test.tsandreplay.test.tsrun the branch through a real test server and replay its history.