Repository navigation
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
The tools of one step write the tree that worker is standing in, so sending them back to it on a queue it polls alone lets them run at once and see each other's writes through the filesystem. A pin nobody answers moves unstarted work to the shared queue after a schedule-to-start bound; a pinned attempt that started is never retried, because a timeout does not say whether the tool behind it stopped.
moetemp
force-pushed
the
moe/worker-affinity
branch
from
September 15, 2026 01:01
ef21ffc to
e0f2a64
Compare
moetemp
force-pushed
the
moe/pinned-queues
branch
from
September 15, 2026 01:01
012f1f5 to
ab3408a
Compare
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends the tools and the seal of a step back to the worker that made its model call, on a queue that worker polls on its own. On by default;
OPENCODE_TEMPORAL_STEP_AFFINITY=0turns it off.The tools of one step write the tree that worker is standing in. Keeping them there lets them run at once and see each other's writes through the filesystem, rather than by shipping the tree between hosts, which is what made them serial in the PR below. The queue is keyed by host as well as directory, because two containers can serve
/projectand share none of it.A pin nobody answers moves unstarted work to the shared queue after a schedule-to-start bound. A pinned attempt that started is never retried: a timeout settles the workflow's promise without saying whether the tool behind it stopped, so a retry could run a tool twice. Shared dispatches wait for the pinned batch before they run, for the same reason.
Tests: the
stepped turn, pinned to a workercases inpackages/temporal/test/stepped-turn.test.ts.