ci: retry and cache Docker dependency downloads - #482
Draft
THardy98 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker image builds download the repository Go module graph inside BuildKit, so the Go cache restored on the GitHub Actions host does not protect that step. A transient HTTP/2 failure from proxy.golang.org therefore failed an otherwise unrelated TypeScript source-worker job, and the same cold-download exposure exists in every worker and CLI Dockerfile.
This change makes that dependency layer resilient in two complementary ways. Each Dockerfile retries go mod download up to three times with short bounded backoff. GitHub Actions also uses scoped version-2 BuildKit caches for regular workers, source-built workers, the CLI image, and multi-platform publishing. Cache export is best-effort, scopes are isolated by job, language, and platform set, and runtime cache credentials remain environment-only rather than appearing in the logged Docker command.
Local builds are unchanged because cache arguments are added only when OMES_BUILDKIT_CACHE_SCOPE is set by CI. There is no runtime or deployment migration. The draft status allows the first CI cycle to validate cold-cache behavior and subsequent runs to demonstrate restored intermediate layers.
Validation:
Failure motivating this change: https://github.com/temporalio/omes/actions/runs/34357997033/job/102487464734