Forward kitchen sink signal arguments - #469
Open
stephanos wants to merge 5 commits into
Open
Conversation
stephanos
force-pushed
the
kitchen-sink-signal-args
branch
from
September 7, 2026 16:08
9024117 to
89dbc1e
Compare
stephanos
commented
Sep 9, 2026
| // Arguments for the handler | ||
| repeated temporal.api.common.v1.Payload args = 4; | ||
| // Argument for the handler | ||
| temporal.api.common.v1.Payload arg = 4; |
Collaborator
Author
There was a problem hiding this comment.
We only need one; a payload can contain lists inside if needed. Simpler.
Contributor
There was a problem hiding this comment.
nit: Argument for the handler, uses lists to represent multi-arg input.
No strong feelings either way if you feel this is redundant.
stephanos
force-pushed
the
kitchen-sink-signal-args
branch
from
September 9, 2026 02:56
a5a3316 to
98f37f4
Compare
stephanos
marked this pull request as ready for review
September 9, 2026 02:57
stephanos
force-pushed
the
kitchen-sink-signal-args
branch
from
September 9, 2026 03:07
98f37f4 to
9c9af99
Compare
THardy98
reviewed
Sep 9, 2026
THardy98
left a comment
THardy98
left a comment
Contributor
There was a problem hiding this comment.
I don't see a corresponding change for the Typescript worker
| // Arguments for the handler | ||
| repeated temporal.api.common.v1.Payload args = 4; | ||
| // Argument for the handler | ||
| temporal.api.common.v1.Payload arg = 4; |
Contributor
There was a problem hiding this comment.
nit: Argument for the handler, uses lists to represent multi-arg input.
No strong feelings either way if you feel this is redundant.
Collaborator
Author
|
stephanos
force-pushed
the
kitchen-sink-signal-args
branch
from
September 9, 2026 19:48
d2ae1bf to
e1e2119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward the existing
SendSignalAction.argspayloads from the Go, Java and Python kitchen sink workers instead of always delivering an empty signal.