Add Nexus workflow messaging actions - #464
Merged
Merged
Conversation
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 4, 2026 23:32
3c7f618 to
e7241c7
Compare
stephanos
changed the base branch from
per-sdk-namespace-stacked
to
stephanos/nexusAttachCallback
September 4, 2026 23:32
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 5, 2026 01:41
e7241c7 to
f2c1868
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 5, 2026 01:53
f2c1868 to
2d87a80
Compare
stephanos
changed the title
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
3 times, most recently
from
September 7, 2026 15:50
d019aab to
0e043c3
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 7, 2026 18:07
0e043c3 to
a5b7081
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 7, 2026 18:35
a5b7081 to
4b38d58
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 7, 2026 21:09
4b38d58 to
2694441
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
2 times, most recently
from
September 8, 2026 02:00
340ecd4 to
67a21ee
Compare
stephanos
commented
Sep 8, 2026
stephanos
commented
Sep 8, 2026
|
|
||
| execution := executions.Executions[0] | ||
| historyIter := temporalClient.GetWorkflowHistory(t.Context(), execution.Execution.WorkflowId, execution.Execution.RunId, false, enums.HISTORY_EVENT_FILTER_TYPE_ALL_EVENT) | ||
| func getWorkflowHistory( |
stephanos
commented
Sep 8, 2026
| } | ||
| return "", nil, fmt.Errorf("do_update must recognizable variant") | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
^ new helpers for re-use
stephanos
commented
Sep 8, 2026
| workflowAction := cmp.Or(action.WorkflowAction, &kitchensink.NexusWorkflowAction{}) | ||
| if workflowAction.GetStart() == nil { | ||
| break | ||
| switch workflowAction.GetAction().(type) { |
Collaborator
Author
There was a problem hiding this comment.
This file is the main change:
stephanos
marked this pull request as ready for review
September 8, 2026 16:55
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 8, 2026 20:49
73106ca to
5cd9c36
Compare
mavemuri
approved these changes
Sep 8, 2026
| return mapIsSuperset(x, yMap) | ||
| } | ||
| return false | ||
| case []any: |
| TaskQueue: cmp.Or(input.GetStartOptions().GetTaskQueue(), temporalnexus.GetOperationInfo(ctx).TaskQueue), | ||
| WorkflowExecutionTimeout: 60 * time.Minute, | ||
| WorkflowIDConflictPolicy: startOptions.GetWorkflowIdConflictPolicy(), | ||
| WorkflowIDConflictPolicy: enumspb.WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING, |
There was a problem hiding this comment.
Just checking if this is intentional - in the base pr, looks like this is in the proto - why hardcode it now? maybe a similar cmp.Or like above instead?
Collaborator
Author
There was a problem hiding this comment.
Good question! It was because Signal-with-Start I thought required USE_EXISTING, but I checked and it also supports TERMINATE_EXISTING. I'll make the change to use the start options 👍
Collaborator
Author
There was a problem hiding this comment.
(server default is USE_EXISTING if it's not defined)
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 9, 2026 02:05
be3dc25 to
5720668
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 9, 2026 03:01
5720668 to
ef69b93
Compare
stephanos
force-pushed
the
nexus-sdk-ergonomics-ops
branch
from
September 9, 2026 03:10
ef69b93 to
f6d9f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
NexusWorkflowActionwith signal and update variants using the existingDoSignalandDoUpdateaction types.