Allow CLI load runs to continue after terminal iteration failures - #461
Open
THardy98 wants to merge 2 commits into
Open
Allow CLI load runs to continue after terminal iteration failures#461THardy98 wants to merge 2 commits into
THardy98 wants to merge 2 commits into
Conversation
THardy98
force-pushed
the
fix/graceful-driver-failure
branch
3 times, most recently
from
September 10, 2026 13:57
2a8c379 to
1d9f0ae
Compare
THardy98
marked this pull request as ready for review
September 10, 2026 14:39
THardy98
marked this pull request as draft
September 10, 2026 14:40
THardy98
marked this pull request as ready for review
September 10, 2026 17:10
THardy98
force-pushed
the
fix/graceful-driver-failure
branch
from
September 11, 2026 14:01
1d9f0ae to
9797459
Compare
THardy98
added this pull request to stack #487
September 11, 2026 14:02
ContinueOnIterationFailure already lets GenericExecutor finish all configured work, but callers can only identify the degraded completion by matching an error string. Return IterationFailuresError with outcome counts and elapsed time so callers can apply policy without changing the library default. Emit a final warning with the outcome counts so degraded completion remains visible.
Expose GenericExecutor continuation through a CLI policy flag while keeping fail-fast as the default for existing commands, CI, and automation. Continue mode treats only the typed degraded completion as successful; cancellation, timeout, joined, and other run-level errors remain fatal.
THardy98
force-pushed
the
fix/graceful-driver-failure
branch
from
September 11, 2026 16:20
9797459 to
36a18f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
omes run-scenarioandrun-scenario-with-workernow accept--iteration-failure-policy=fail-fast|continue. Existing commands remainfail-fastby default; operators running sustained load can explicitly selectcontinue. Retry count and terminal-failure policy remain independent.The loadgen library still defaults to fail-fast. When continuation is enabled, it returns a typed
IterationFailuresErrorcontaining attempted, succeeded, failed, and elapsed values. The CLI treats only that degraded completion as successful incontinuemode, so cancellation, timeout, validation, connection, joined, and other run-level errors remain fatal. Every terminal failure remains an error log, and a completed degraded run emits a structured warning with its outcome counts.The operational observability changes are intentionally separated into stacked follow-up PR #486.
Why?
A terminal iteration failure currently ends an
omes run-scenarioinvocation. In a Kubernetes load-driver deployment, that turns a transient workflow failure into a container restart and stops the configured load run early. This PR adds an explicit continuation mode for that use case while preserving existing fail-fast behavior for unflagged CLI, CI, and automation callers.Checklist
Closes [Feature Request] Gracefully handle load driver failures #453
How was this tested:
cmd/omestests and focused race-detector coverage pass locally.Any docs updates needed?
docs/running.mdanddocs/authoring-scenarios.mdfor the opt-in policy, warning behavior, and relationship to retries.