Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Docs build passed |
📖 Docs PR preview links
|
| @@ -0,0 +1,254 @@ | |||
| --- | |||
| id: nexus-standalone-activity | |||
| title: Nexus Standalone Activity | |||
There was a problem hiding this comment.
Reading this gave me an interesting thought . Should this doc live under SAA rather than under Nexus. The PRD names this feature is Standalone Activity: Start from Nexus, which is actually a clearer name for this. If we leave here the name really should be something like Standalone Activity Started By Nexus
There was a problem hiding this comment.
I had a lot of similar thoughts about naming confusion. I'm not at all sure!
|
Looks great! When it's ready for review, feel free to drop a comment and post it in the slack channel then someone from the team will review it! |
| ) (temporalnexus.TemporalOperationResult[GreetingOutput], error) { | ||
| return temporalnexus.StartActivity(ctx, nc, client.StartActivityOptions{ | ||
| ID: "greet-" + opts.RequestID, | ||
| TaskQueue: TaskQueueName, |
There was a problem hiding this comment.
nit: Task queue should be optional
There was a problem hiding this comment.
If I am getting this right, it seems like it is in the other four languages, but not Java? That might be something we need to fix
| </SdkTabs.DotNet> | ||
| </SdkTabs> | ||
|
|
||
| ## Coming from the earlier handler APIs |
There was a problem hiding this comment.
I would add a note that there is no issue if they have workflow operations in progress. TemporalOperationHandler can cancel them just fine
Co-authored-by: Quinn Klassen <klassenq@gmail.com>
Co-authored-by: Quinn Klassen <klassenq@gmail.com>
| // request targeting the same Activity Execution instead of sending a second | ||
| // notification. | ||
| .setId("notify-" + ctx.getRequestId()) | ||
| .setTaskQueue(HandlerWorker.DEFAULT_TASK_QUEUE_NAME) |
There was a problem hiding this comment.
Nit: I think we can remove this from all the code since it is not needed
Note for documentation reviewers - do not review or merge. I am sending this to some internal folks as we are discussing what we want to do.
Matching sample Java code: temporalio/samples-java#793
┆Attachments: EDU-6917 Nexus V2 Documentation - don't review or merge!!