Skip to content

feat: code-generate the system Nexus operations registry - #1090

Draft
spkane31 wants to merge 2 commits into
mainfrom
spk/sne-codegen
Draft

spkane31 wants to merge 2 commits into
mainfrom
spk/sne-codegen

Conversation

@spkane31

Copy link
Copy Markdown
Contributor

Related issues

Follow up for #1017. There will be a third required PR to temporalio/api-go to trigger the CI job defined in this repo

What changed?

Replaces the originally hand crafted systemNexusOps map with code generation. New "exposed" operations from go.temporal.io/api will not need manual updates.

Checklist

Tests

  • TestParseDiscoversWorkflowService, TestGenerateCode — generator unit tests.
  • TestSystemNexusGenUpToDate — fails if the generated file is stale after an api-go bump.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sean Kane seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants