Show live STREAMING state for StreamPublisher node#24
Merged
Conversation
Add StreamPublisher to the editor's LIVE_STREAM_NODE_TYPES so that once it emits streaming=true with a stream_url, the node shows the STREAMING badge and a Stop stream button instead of the static 'SNAPSHOT - NOT UPDATING / Go live' message. Note: this branch also snapshots pre-existing in-progress editor/server/docs work that was uncommitted in the working tree; the reviewable change here is the streaming live-UI fix in editor/src/components/BlackNode.tsx.
The action=start param is hidden in the compact node, and generic 'Go live' never set it, so the publisher stayed on the snapshot badge. Add a Go live button (and suppress the snapshot badge for StreamPublisher) that sets action=start and cooks, so it flips to the STREAMING/Stop state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
StreamPublisherto the editor'sLIVE_STREAM_NODE_TYPESset inBlackNode.tsx. Once the node emitsstreaming=truewith astream_url, it now shows the STREAMING badge and a Stop stream button instead of the staticSNAPSHOT - NOT UPDATING / Go livemessage. This was the cause of 'pressed go live and it says snapshot'.Heads up
This branch also snapshots pre-existing in-progress editor/server/docs work that was uncommitted in the working tree (BlackNode.tsx is entangled with uncommitted
store.ts/api.ts/portColors.ts, so the fix can't be isolated into a buildable one-file PR). The reviewable change for this PR is the streaming live-UI fix; the rest is your existing WIP captured so the branch builds. Cherry-pick or merge as suits your workflow.Pairs with blacknode-dataset generic streaming (StreamPublisher/TrajectorySmoother) already pushed.