[cherry-pick: release-v0.80.x] fix(kustomize): move platform-specific CRDs to shared base - #3880
Open
tekton-robot wants to merge 1 commit into
Open
[cherry-pick: release-v0.80.x] fix(kustomize): move platform-specific CRDs to shared base#3880tekton-robot wants to merge 1 commit into
tekton-robot wants to merge 1 commit into
Conversation
Newer kustomize versions enforce a security restriction that rejects direct file references pointing outside the kustomization root. config/kubernetes/base and config/openshift/base both referenced CRD files via ../../base/generated-crds/..., which violates that restriction and caused kustomize build to silently fail during releases (the error was swallowed because the pipeline does not set pipefail). Move tektondashboards and tektonaddons CRDs from their platform- specific kustomization.yaml files into config/base/kustomization.yaml where controller-gen already writes all generated CRDs. The extra CRDs on each platform are harmless — their reconcilers are platform-gated. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
tekton-robot
added
the
release-note-none
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #3878
Changes
Newer kustomize versions enforce a security restriction that rejects
direct file references pointing outside the kustomization root.
config/kubernetes/baseandconfig/openshift/baseboth referencedCRD files via
../../base/generated-crds/..., which violates thatrestriction and caused
kustomize buildto silently fail duringreleases (the error was swallowed because the pipeline does not set
pipefail).This manifested as the
koparsestep failing with:because
ko resolvereceived empty stdin (from the failed kustomizepipe) and produced an empty
release.yaml.Move
tektondashboardsandtektonaddonsCRDs from their platform-specifickustomization.yamlfiles intoconfig/base/kustomization.yamlwherecontroller-genalready writes all generated CRDs. The extra CRDs oneach platform are harmless — their reconcilers are platform-gated.
Root cause introduced by: 1ae0906 (Cleanup manual CRDs and use generated
CRDs in kustomize)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
Made with Cursor