Conversation
Restore alt.renderers.enable('png') that was dropped during the 2025
modernization attempt, and replace removed kdeplot shade= with fill=.
… RSPM binary R packages
…ions custom.css and pygments-native.css were deleted from the repo in 2018 but still referenced by the template; the live site was serving stale copies from S3, which made the styling impossible to reproduce from source.
CI is GitHub Actions with uv; dependency spec lives in pyproject.toml and uv.lock. The Makefile s3/cloudfront targets' scripts are gone too since deployment is Netlify.
tdhopper
marked this pull request as ready for review
August 5, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The site has not built since 2020: the November 2025 modernization left Altair's PNG renderer disabled (12 of 66 example cells produced no images, and render.py aborts on the first missing one), and the CSS the template links was deleted from the repo in 2018, so a successful build still looked wrong. With both fixed, the full notebook executes cleanly and the rendered site matches the old aesthetic. Verified locally end to end: all 66 plots render, tests pass.
Files to review (24, +3,249 / -900, mostly uv.lock and deletions):
Examples.ipynb(start here)alt.renderers.enable("png"); one seaborn cell moves off the removedshade=argument..github/workflows/deploy.ymlweb/css/custom.css,web/css/pygments-native.css41aca4c^, which deleted them while the template kept linking them. S3 served stale copies for years.tests/test_plots.pyuv.lockReviewer notes
make travis..travis*,environment.yml,requirements.txt,runtime.txt,netlify_deploy.sh, and the three stale migration docs from November. Dependency truth is pyproject.toml + uv.lock.web/to the Cloudflare Pages projectpythonplot: master pushes deploy with--branch=main(that project's production branch, serving pythonplot.com), everything else gets a preview URL.CLOUDFLARE_ACCOUNT_IDis already set as a repo secret. Tim still needs to addCLOUDFLARE_API_TOKEN(Cloudflare dashboard, API token with the Cloudflare Pages: Edit permission) before the deploy step can pass; the build steps run regardless. The upload path itself is verified: a local wrangler run of the same command produced https://fix-build.pythonplot.pages.dev, which serves the rendered site.