Fix npm audit vulnerabilities and unblock Renovate lockfile maintenance - #3019
Merged
Conversation
Sets minimumReleaseAge to null for lockFileMaintenance, matching the config already proven in tanem/react-svg. The repo-wide 3-day release soak was also applying to weekly lock refreshes, and since a full refresh always pulls in something published within 3 days, the resulting PR's renovate/stability-days check could never pass - deadlocking #2929 since 2025-11-24 and leaving 23 transitive dev dependency alerts unaddressed. Also: - Bump @babel/core to 7.29.7 (pinned exact, so the lockfile refresh alone couldn't reach the patched version). - Add an override pinning brace-expansion to ^5.0.8, fixing GHSA-mh99-v99m-4gvg (a DoS newly published 2026-07-24) in nested copies that eslint/jest/ts-jest otherwise keep on 1.x/2.x. - Migrate examples/react-router-v6 to react-router-dom 7.18.2, fixing GHSA-jjmj-jmhj-qwj2 (open redirect/XSS), which has no fix in the 6.x line. Renamed to examples/react-router since the version is no longer relevant. Verified with a headless browser that navigation and the progress bar animation still work correctly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tanem
force-pushed
the
chore/fix-dependabot-vulnerabilities
branch
from
July 29, 2026 08:16
587ee45 to
fa78bfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimumReleaseAge: nullinsidelockFileMaintenanceinrenovate.json, matching the config already proven intanem/react-svg. The repo-wide 3-day release soak was also applying to weekly lock refreshes; since a full refresh always pulls in something published within the last 3 days, the resulting PR'srenovate/stability-dayscheck could never pass. This deadlocked Lock file maintenance #2929 since 2025-11-24 and left 23 transitive dev-dependency alerts unaddressed - the same root cause behind Fix npm audit vulnerabilities #3016 needing to be done by hand in March.@babel/coreto7.29.7(it's pinned exact, so the lockfile refresh alone couldn't reach the patched version).overridesentry pinningbrace-expansionto^5.0.8, fixingGHSA-mh99-v99m-4gvg(a DoS newly published 2026-07-24) in nested copies that eslint/jest/ts-jest otherwise keep on 1.x/2.x.examples/react-router-v6toreact-router-dom@7.18.2, fixingGHSA-jjmj-jmhj-qwj2(open redirect leading to XSS), which has no fix in the 6.x line. Renamed the example directory toexamples/react-routersince the version number is no longer relevant.npm auditat the repo root now reports 0 vulnerabilities.The example's
npm auditstill flags one advisory (GHSA-qwww-vcr4-c8h2, react-router RSC-mode CSRF), but per the advisory itself this "only affects your application if you are using the unstable RSC APIs" - this example is a plain client-sideBrowserRouterapp and doesn't use them. Its only fix isreact-router@8.3.0, butreact-router-domwas never republished past 7.18.2 in the v8 line, so actually closing it would mean droppingreact-router-domfor the barereact-routerpackage - a separate, larger migration left out of this PR.Test plan
npm ci && npm testpasses at the root (check:format, check:types, lint, build, all jest configs across the React version matrix)npm auditat the root reports 0 vulnerabilitiesrenovate-config-validator renovate.jsonpassesexamples/react-routerbuilds (npm run build) and was verified end-to-end with a headless browser: navigated between all four routes, confirmed the NProgress bar animates on each transition and the HSL/RGB content updates correctly, with no console errorsrenovate/stability-dayscheck🤖 Generated with Claude Code