Repository navigation
Key a splat by its source line and not the function it was inlined into - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 6.12.111 X64,
rk testfailed the rucc kernel on one splat that only its log had:WARNING: CPU: N PID: N at drivers/gpu/drm/drm_rect.c:137 drm_calc_scale+NThe reference log has the same warning at the same line, the same number of times, from the same KUnit cases (
negative srcandnegative dstin drm_rect_test expect theWARN_ON). The only difference is the function name. GCC inlines the staticdrm_calc_scaleintodrm_rect_calc_hscaleanddrm_rect_calc_vscale, and rucc keeps it as a function, so the reference key ends indrm_rect_calc_hscale+N.The function after a source location tells which function the code was inlined into, and that is a compiler choice. This change drops it from the normalized first line when a source location comes before it. The source location stays, so a warning at a different line is still a different splat. Lines with no source location, such as
BUG: unable to handle page fault, do not change.Tested on server2:
cargo fmt --check -p rk,cargo clippy -p rk --all-targets -- -D warningsandcargo test -p rk(136 passed, with a new test for this case).