Repository navigation
Turn off the KUnit fault test in the test fragments - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 6.12.111 the
bootunit failed for both the gcc kernel and the rucc kernel in every KUnit run. The cause is thekunit_faultsuite. 6.12 builds it by default (CONFIG_KUNIT_FAULT_TEST=y), and it dereferences NULL on purpose to show that KUnit survives a fault. The test fragment setsCONFIG_PANIC_ON_OOPS=yand the command line hasoops=panic, so that oops ends the run. Every suite afterkunit_faultdid not run, and the 6.12 grade counted only 123 units.This change turns
CONFIG_KUNIT_FAULT_TESToff in the fragments for E8 to E11. A missing symbol asked to bencounts as taken, so kernels without the symbol (6.1) and kernels that already default it to off (7.2) do not change. The setting is the same for both builds, so the grade stays fair.Changes:
configs/test.fragment.E*: add# CONFIG_KUNIT_FAULT_TEST is not setafterCONFIG_KUNIT_ALL_TESTS=m, and say in the header that this is the one thing the fragment turns off.docs/plan/11-boot-and-tests.md: show the line in 11.1 and add a note that gives the reason.crates/rk/src/kconfig.rs:the_committed_fragments_readnow checks that each fragment turns the fault test off.Tested on server2:
cargo fmt --check -p rkandcargo test -p rk kconfig(8 passed). The 6.12.111 X64 and X32 grades are being run again with the new fragment.