Repository navigation
Read BTF alone in rk btf and write qualifiers in one order - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the first run of
rk btfon real pahole output showed, on a test file built with gcc-14 and rucc for arm64 and encoded withpahole --btf_encode_detached.rk btfnow reads a file that is BTF alone, which is whatpahole --btf_encode_detachedwrites and what/sys/kernel/btf/vmlinuxis, besides an ELF file with a.BTFsection. pahole needs llvm-objcopy to add the section itself, so detached BTF is the easy way to compare single objects.A run of
const,volatileandrestrictis now written in one order. gcc describesconst volatile intas volatile over const and rucc as const over volatile, which means the same type and should not be a finding.The rest of what the run found is rucc's DWARF and goes to tamnd/rucc: base type names (
unsigned longwhere gcc sayslong unsigned int), a typedef lost in a function pointer's return type, multi-dimensional arrays nested instead of one array type with several subranges, and typedefs nothing uses.Part of #6 and #7.