Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K5's fourth criterion is the BTF differential: both builds' vmlinux must describe the same types and the same functions, and functions only one has because of inlining are listed and not failed. Nothing measured it, and the runners had no pahole, so kconfig dropped
DEBUG_INFO_BTFfrom the distro configs.rk btf --reference DIR --other DIRreads the.BTFsection of each vmlinux with theobjectcrate and parses it by hand. Type IDs differ between builds, so every named struct, union, enum, typedef, int, float, var and decl tag is written out with the types it uses named, and anonymous ones written in full where they are used. A name can have more than one description, since two files can define different structs of one name, so each name maps to a set. Functions map to their linkage and prototype, parameter names included.It fails on a name both builds describe differently, a type only one has, and a function both have with different prototypes. Functions only one has are listed. It takes
--save FILEand accepts a saved file or a vmlinux path in place of a build, likerk frames.The nightly installs dwarves (1.25 on Ubuntu 24.04, which the plan asks for), runs
rk btfafterrk framesand adds a btf column to the headline. Exit status 2, which is what a build without.BTFgives (tinyconfig), shows as not run.Part of #6 and #7.