Give back 130 entries that were copied through as markup - #55
Merged
Conversation
pydocvi 0.1.10. is_noop stripped the markup and asked whether anything was left, and a role written `:ref:`text <target>`` has words a reader sees inside the backticks. Stripping took them away with the target. So 130 entries were copied through here wearing `passthrough=noop`, which is this tool's claim that there was nothing in them to translate. There was: `A logging cookbook`, `Basic Tutorial`, `Configurable memory allocators`, `Explanation of the object-oriented interface`. 117 of them are :ref:, and the rest are :rfc:, :term:, :doc: and :option:. They are untranslated now rather than copied, which is what they are. Sphinx renders the English for an empty msgstr and rendered it for the fuzzy copy too, so no page changes. What changes is that they will be queued on the next run and checked from now on, and neither had ever happened. Audit: 2,259 findings, 29 of 41 checks passing, 4 hard checks failing, all unchanged. Coverage in tier 6 drops 2,231 to 2,176 passthrough entries, which is the same 130 counted where they should have been counted all along.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built with pydocvi 0.1.10 (tamnd/python-docs-vi-translator#59).
is_noopstripped the markup and asked whether anything was left. A role written:ref:`text <target>`has words a reader sees inside the backticks, and stripping took them away with the target.So 130 entries were copied through here wearing
# pydocvi: passthrough=noop, which is this tool's written claim that there was nothing in them to translate. There was:117 carry
:ref:, the rest:rfc:,:term:,:doc:and:option:. All 130 display strings were read before the rule shipped.They are untranslated now rather than copied, which is what they are. Sphinx renders the English for an empty
msgstrand rendered it for the fuzzy copy too, so no page changes for a reader today. What changes is that they will be queued on the next fleet run and checked from now on, and neither had ever happened.Audit
Nothing moves, which is the expected result: these entries were invisible to every check and are now merely untranslated, and an untranslated entry is not a finding. The coverage report is where the change shows, tier 6 going from 2,231 to 2,176 passthrough entries. Same 130, counted where they should have been counted all along.