Keep import in English, at glossary v2 - #54
Merged
Conversation
pydocvi 0.1.9. L02 no longer reports an entry whose whole msgid is a term the glossary keeps in English, so the decision moves out of the check and into a written row that G03 checks in both directions. Most of the work was already done. sys, builtins, exec and NaN were keep_en rows in v1 already, and what was missing was the check reading them. `import` is the one row this adds, for the 5 index entries that read `import` and name the statement. Infinity is deliberately left as `vô cực`. It is the right answer for the 80 prose entries that mean the mathematical concept and the wrong one for the single index entry next to NaN, and a row cannot say both. The prose wins and that one entry stays an L02 finding. Audit: 2,259 findings, 29 of 41 checks passing, 4 hard checks failing. L02 139 to 86. G03 81 to 94, which is the same change read the other way: 13 entries where `import` appears in prose and the translation rendered it in Vietnamese. The corpus said both, and now one of them is a finding. G06 0 to 860 is the version bump itself. Every machine-translated entry was made against v1, `stale --glossary` is what re-queues them, and that needs the fleet. It is soft and it is counting, not failing.
This was referenced Aug 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built with pydocvi 0.1.9 (tamnd/python-docs-vi-translator#57).
L02no longer reports an entry whose wholemsgidis a term the glossary keeps in English. The decision moves out of the check and into a written row thatG03then checks in both directions.Most of it was already written.
sys,builtins,execandNaNwerekeep_enrows in v1 already, and what was missing was the check reading them.importis the one row this PR adds, for the 5 index entries that readimportand name the statement.Infinity is deliberately not added
The proposal had it. Measuring it first is what stopped it:
msgidis exactlyInfinityvô cựcis right for the 80 and wrong for the 1, and a row cannot say both. The prose wins, and that single index entry stays anL02finding rather than 80 entries being told to un-translate a word.Audit
G03at 94 is the same change read the other way: 13 entries whereimportappears in prose and the translation rendered it in Vietnamese anyway. The corpus said both things, and now one of them is a finding.G06at 860 is the version bump itself. Every machine-translated entry was made against v1,stale --glossaryis the command that re-queues them, and that needs a fleet run. It is a soft check and it is counting rather than failing, which is what its docstring says it is for.Follow-up on the terminology this exposed: tamnd/python-docs-vi-translator#58. The glossary keeps
list,typeandBooleanin English and has no opinion aboutobjectormodule, and all five are the same kind of Sphinx index category.