Mark 67 code entries as copied rather than translated - #53
Merged
Conversation
pydocvi 0.1.8. The block rule reads three more shapes of code: a signature quoted without its body, a line with a comment on the end, and a call whose arguments are quoted strings. 67 entries move out of prose, and apply now copies a code entry before asking whether a person signed it. Five entries had been sitting here translated and not fuzzy with nothing behind them, because the segments that explained them left the memory when the classifier got stricter. S04 reported all five. They now carry `# pydocvi: passthrough=literal_block` and say where the text came from. The text itself is unchanged, because it was already the source byte for byte, which is what L01 was reporting them for. The rest of the diff is the header stamp and the writer's line wrapping on the entries it rewrote. Audit: 1,439 findings, 30 of 41 checks passing, 4 hard checks failing, down from 1,459 and 6. S04 5 to 0 and A01 4 to 0 in the same run. L01 9 to 4, and the 4 left are 3 copyright notices and a Monty Python sketch, both of which are policy questions rather than bugs. L02 144 to 139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built with pydocvi 0.1.8 (tamnd/python-docs-vi-translator#55 and #56).
The block rule now reads three more shapes of code, so 67 entries move out of prose:
A signature quoted without its body, a line with a comment on the end, and a call whose arguments are quoted strings. All 67 were read one at a time before the rule shipped and there is no prose among them.
Five entries here had been sitting translated and not fuzzy with nothing behind them, because the segments that explained them left the memory when the classifier got stricter.
S04reported all five. They now carry# pydocvi: passthrough=literal_block. The text is unchanged, because it was already the source byte for byte, which is whatL01was reporting them for.The rest of the diff is the header stamp and the writer's line wrapping on the entries it rewrote. No translated string changes in this PR.
Audit
L01's remaining 4 are 3 copyright notices and a transcript of a Monty Python sketch. Both are policy questions about what should be translated at all, not defects.