Strip the leading space on 47 human entries - #51
Merged
Conversation
P04 had 47 findings and every one was the same shape: the source has no leading whitespace and the translation has one space. 46 of them are Footnotes rendered as ' Chú thích' and the last is raises rendered as ' kích hoạt các ngoại lệ'. These are inherited Transifex entries with no fuzzy flag and no provenance comment, so apply leaves them alone and P04 had been red on them since the check was written. Editing them by hand is the only way they change, and apply is right not to start. Fixed from the audit's own finding list rather than a regex over the corpus, so the edit reaches exactly the entries the check named. Then re-rendered through apply, because polib's writer disagrees with ours on wrapping and saving with it directly put S08 to 46. P04 is 0. Footnotes still has two renderings, Chú thích cuối trang in 98 entries and Chú thích in 50, which is issue #49 and a translation decision rather than a whitespace one. Also pins v0.1.5, which is the tool that produced the reports in this commit. Its fence licence takes P08 and L03 to 0 as well, so the corpus goes from nine failing hard checks to six and from 25 checks passing to 28.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49 in part.
P04had 47 findings and every one was the same shape: the source has no leading whitespace and the translation has one space.Footnotes' Chú thích'raises' kích hoạt các ngoại lệ'These are inherited Transifex entries with no fuzzy flag and no provenance comment, so
applyleaves them alone andP04had been red on them since the check was written. Editing them by hand is the only way they change, andapplyis right not to start.How
Driven off the audit's own finding list rather than a regex over the corpus, so the edit reaches exactly the entries the check named and nothing else. Then re-rendered through
apply, because polib's writer disagrees with ours on wrapping: saving with it directly tookS08from 0 to 46, which is the same lesson as thePO-Revision-Dateone from a different angle. Only our renderer writes these files.Where it leaves the audit
P04is 0.P08andL03are 0 as well, from the fence licence in tamnd/python-docs-vi-translator#51, which this commit picks up by pinningv0.1.5.apply --checkis clean andS08is 0.Left open on #49
Footnotesstill has two renderings,Chú thích cuối trangin 98 entries andChú thíchin 50. That is a translation decision and a glossary entry rather than a whitespace fix, so it stays on the issue.