Re-apply under pydocvi 0.1.4 - #48
Merged
Merged
Conversation
The identifier rule used to call any single English word an identifier, so apply copied 2808 headings through from the msgid and stamped each one passthrough=version_marker, which is a claim that the string needs no translation. Availability 62 times, Exceptions 25, Author 21, Introduction 18, Description 15, Notes 11. This drops those msgstrs, which puts the entries back to untranslated, which is what they are. Passthrough goes from 13900 to 11074 and untranslated from 70934 to 73760. Tier 1 goes from 2 untranslated to 31. None of that is new breakage: the strings were English before and they are English now, and the difference is that the corpus no longer says they were meant to be. apply --check is clean and S08 is back to 0. The audit total moves 1270 to 1410 for the same reason in reverse. Narrowing the rule puts 6558 human-written entries into Corpus.prose() for the first time, so the checks that read a translation can see them, and L02 goes from 10 findings to 144. About 96 of those are ordinary words left in English by a reviewer, module 41 times, object 36, type 12. The rest are identifiers a reviewer was right to keep, sys 20 and builtins 8, which L02 has no way to tell apart from the others yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tamnd/python-docs-vi-translator#47 narrowed the identifier rule.
is_version_markerused to call any single token of identifier characters an identifier, and a single English word is a single token of identifier characters, soapplycopied 2 808 headings through from themsgidand stamped each onepassthrough=version_marker. That stamp is a claim that the string needs no translation.AvailabilityExceptionsAuthorIntroductionDescriptionNotesThis run drops those
msgstrs, which puts the entries back to untranslated, which is what they are.What the numbers do
None of that is new breakage. The strings were English on the page before this and they are English on the page after it. What changed is that the corpus no longer claims they were meant to be.
apply --checkis clean andS08is back to 0, so the blocking gate holds.Why the audit total goes up
1,270 findings to 1,410, for the same reason in reverse. Narrowing the rule puts 6,558 human-written entries into
Corpus.prose()for the first time, so the checks that read a translation can finally see them.L02goes from 10 findings to 144 over 20 distinct msgids. About 96 are ordinary words a reviewer left in English:module41 times,object36,type12,Boolean4,Lists3. The other 38 are identifiers a reviewer was right to keep,sys20 andbuiltins8 andimport5, andL02has no way to tell those apart from the others yet. That wants akeptglossary entry per identifier, filed separately.Still nine hard checks failing and the audit step stays advisory.